linux-kernel - Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AA89B02.1050909@zytor.com>
Date:	Wed, 09 Sep 2009 23:21:54 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
CC:	Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty
 devices are requested

On 09/09/2009 09:05 PM, Mauro Carvalho Chehab wrote:
>  {
> +	static char ptychar[] = "pqrstuvwxyzabcde";
> +

Oh yes, this should be "static const char ...".

> +	 *   The second nibble encoded with ptychar;
> +	 *   The first nibble, printed in hexadecimal;
> +	 *   The other nibbles, printed in hexadecimal.

The last two are in the wrong order (and you reversed the order of the
code from my example, which made that harder to see.)

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/