linux-kernel - Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090910150716.66310f02@lxorguk.ukuu.org.uk>
Date:	Thu, 10 Sep 2009 15:07:16 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mauro Carvalho Chehab <mchehab@...radead.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty
 devices are requested

> * The remaining nibbles are represented by one of 0123456789abcdef letters,
>   indicating the 1st through 16th nibble value, starting from the most
>   significative nibble to the least significative nibble, excluding the
>   second nibble (that were already represented).

This is a real step back.

It now wastes all the tty[e-p]%d namespace. ttyp%d for > 255 at least
only uses one for this irrelevant area.

I actually have another proposal having reviewed the user space code.

Limit the BSD ptys to 256. Nothing uses them, the C library routines for
their allocation would need glibc modifying (which takes about five years
for a tty change it seems anyway). It's basically a huge amount of work
for no purpose at all.

So lets limit BSD ptys (unused anyway) to 256 and be done with it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/