linux-kernel - Re: mmotm 2009-09-03-16-35 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090910090141.9CC0.A69D9226@jp.fujitsu.com>
Date:	Thu, 10 Sep 2009 09:02:59 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	kosaki.motohiro@...fujitsu.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: mmotm 2009-09-03-16-35 uploaded

> /me slaps self
> 
> I think I see the problem. Can you try this patch please?

After the patch apply, the system boot successful.

Thanks, Mel!

Andrew, Could you please pick this patch?


> ---
> Calculate the number of pageblocks within a range properly
> 
> Patch
> page-allocator-change-migratetype-for-all-pageblocks-within-a-high-order-page-during-__rmqueue_fallback
> is meant to change the pageblock ownership of each pageblock within a
> given range. This is necessary when the buddy to be split is of higher
> order than the pageblock_order. However, the calculation was wrong
> leading to crashes on ia-64 and slightly incorrect behaviour on x86.
> This patch corrects the calculation.
> 
> Signed-off-by: Mel Gorman <mel@....ul.ie>
> --- 
>  mm/page_alloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 4e0ec94..4326280 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -830,7 +830,7 @@ static int move_freepages_block(struct zone *zone, struct page *page,
>  static void change_pageblock_range(struct page *pageblock_page,
>  					int start_order, int migratetype)
>  {
> -	int nr_pageblocks = 1 << (MAX_ORDER - 1 - start_order);
> +	int nr_pageblocks = 1 << (start_order - pageblock_order);
>  
>  	while (nr_pageblocks--) {
>  		set_pageblock_migratetype(pageblock_page, migratetype);



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/