linux-kernel - Re: UWB Kconfig: cannot set UWB to N in gconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090910090806.e8db2300.randy.dunlap@oracle.com>
Date:	Thu, 10 Sep 2009 09:08:06 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Richard Kennedy <richard@....demon.co.uk>
Cc:	David Vrabel <david.vrabel@....com>,
	Roman Zippel <zippel@...ux-m68k.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: UWB Kconfig: cannot set UWB to N in gconfig

On Thu, 10 Sep 2009 11:05:54 +0100 Richard Kennedy wrote:

> I sometimes use 'make gconfig' and I noticed that I cannot disable the
> UWB option -- it just won't let me set it to N.

Not specific to 'gconfig'.

> AFAICT this is because the CONFIG USB_WUSB selects UWB which forces it
> on.

Yes.

> applying this patch fixes the issue but I'm not sure if this is the
> right way to go about it.
> 
> any thoughts?

UWB can be disabled by disabling both of these options that are several
entries below it in the same menu:

USB_WHCI_HCD and USB_HWA_HCD

and then returning to UWB and disabling it.

Should users have to figure that out?  no.


> This is against 2.6.31
> 
> 
> diff --git a/drivers/usb/wusbcore/Kconfig b/drivers/usb/wusbcore/Kconfig
> index eb09a0a..cc97041 100644
> --- a/drivers/usb/wusbcore/Kconfig
> +++ b/drivers/usb/wusbcore/Kconfig
> @@ -5,7 +5,7 @@ config USB_WUSB
>  	tristate "Enable Wireless USB extensions (EXPERIMENTAL)"
>  	depends on EXPERIMENTAL
>  	depends on USB
> -        select UWB
> +        depends on UWB
>          select CRYPTO
>          select CRYPTO_BLKCIPHER
>          select CRYPTO_CBC

use tabs, not spaces.


---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/