linux-kernel - Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty devices are requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AA92487.5080401@zytor.com>
Date:	Thu, 10 Sep 2009 09:08:39 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Alan Cox <alan@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Kay Sievers <kay.sievers@...y.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] char/tty_io: fix legacy pty name when more than 256 pty
 devices are requested

On 09/10/2009 07:07 AM, Alan Cox wrote:
> 
> This is a real step back.
> 
> It now wastes all the tty[e-p]%d namespace. ttyp%d for > 255 at least
> only uses one for this irrelevant area.
> 

Honestly, I *really* don't think the [pt]ty[p-za-e]* namespace should be
used for another purpose, at least until BSD ptys are killed dead, so in
that sense expanding tty[p-za-e][0-9a-f] to tty[p-za-e][0-9a-f]+ is
hardly significant in the namespace pollution sense.  Can you imagine
ttyp1 being a BSD pty and ttyp10 being a completely different kind of
device?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/