linux-kernel - Re: [PATCH] x86: SGU UV Add volatile to macros that access chipset registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AA84BE7.9010304@zytor.com>
Date:	Wed, 09 Sep 2009 17:44:23 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jack Steiner <steiner@....com>
CC:	Chris Friesen <cfriesen@...tel.com>,
	Daniel Walker <dwalker@...o99.com>, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: SGU UV Add volatile to macros that access chipset
 registers

On 09/09/2009 12:38 PM, Jack Steiner wrote:
>  
>  static inline void uv_write_local_mmr8(unsigned long offset, unsigned char val)
>  {
> -	*((unsigned char *)uv_local_mmr_address(offset)) = val;
> +	*((volatile unsigned char *)uv_local_mmr_address(offset)) = val;
>  }
>  

Why aren't you simply using __writeb() here, and the other memory
accessors we already have in the other places?

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/