linux-kernel - [PATCH][mmotm][BUGFIX] kcore use registered physmem information ia64-fix (Was Re: mmotm 2009-09-03-16-35 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090910115859.c2291eb8.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Thu, 10 Sep 2009 11:58:59 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Mel Gorman <mel@....ul.ie>
Subject: [PATCH][mmotm][BUGFIX] kcore use registered physmem information
 ia64-fix (Was Re: mmotm 2009-09-03-16-35 uploaded

On Thu, 10 Sep 2009 10:39:28 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> > > > This release doesn't boot on my ia64 test box.
> > > > After following two patches reverted, booting was successful.
> > > > 
> > > > 	page-allocator-change-migratetype-for-all-pageblocks-within-a-high-order-page-during-__rmqueue_fallback.patch 
> > > > 	Kamezawa-san's kcore patch series
> > > > 
> > > > 
> > > > Mel, Kamezawa-san, Can you please gime me any advise?
> > > 
> > > Kosaki-san, could you give me your .config ?
> > > 
> > Hmm, how about this ?
> 
> Still don't boot.
> 

Ok, I confirmed this one fixes the issue.

==
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
kcore-use-registerd-physmem-information.patch registers physmem information
based on ioresource. Then, this addition is unnecessary.

Why panic:
  At boot, rebuilding kclist for physmem, all KCORE_RAM entries are kfreed.
  Because this ramaining one entires kclist of KCORE_RAM in kernel data area
  to ther list, this causes panic in kclist rebuilding which calls kfree().

Reported-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
---
 arch/ia64/mm/init.c |    3 ---
 1 file changed, 3 deletions(-)

Index: mmotm-2.6.31-Sep3/arch/ia64/mm/init.c
===================================================================
--- mmotm-2.6.31-Sep3.orig/arch/ia64/mm/init.c
+++ mmotm-2.6.31-Sep3/arch/ia64/mm/init.c
@@ -617,7 +617,6 @@ mem_init (void)
 	long reserved_pages, codesize, datasize, initsize;
 	pg_data_t *pgdat;
 	int i;
-	static struct kcore_list kcore_mem;
 
 	BUG_ON(PTRS_PER_PGD * sizeof(pgd_t) != PAGE_SIZE);
 	BUG_ON(PTRS_PER_PMD * sizeof(pmd_t) != PAGE_SIZE);
@@ -639,8 +638,6 @@ mem_init (void)
 
 	high_memory = __va(max_low_pfn * PAGE_SIZE);
 
-	kclist_add(&kcore_mem, __va(0), max_low_pfn * PAGE_SIZE, KCORE_RAM);
-
 	for_each_online_pgdat(pgdat)
 		if (pgdat->bdata->node_bootmem_map)
 			totalram_pages += free_all_bootmem_node(pgdat);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/