linux-kernel - Re: [PATCH 3/3] tracing: add latency format to function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090911145521.GA6119@nowhere>
Date:	Fri, 11 Sep 2009 16:55:25 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Li Zefan <lizf@...fujitsu.com>,
	Mathieu Desnoyers <compudj@...stal.dyndns.org>
Subject: Re: [PATCH 3/3] tracing: add latency format to function_graph
	tracer

On Fri, Sep 11, 2009 at 09:54:55AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@...hat.com>
> 
> While debugging something with the function_graph tracer, I found the
> need to see the preempt count of the traces. Unfortunately, since
> the function graph tracer has its own output formatting, it does not
> honor the latency-format option.
> 
> This patch makes the function_graph tracer honor the latency-format
> option, but still keeps control of the output. But now we have the
> same details that the latency-format supplies.
> 
>  # tracer: function_graph
>  #
>  #      _-----=> irqs-off
>  #     / _----=> need-resched
>  #    | / _---=> hardirq/softirq
>  #    || / _--=> preempt-depth
>  #    ||| /
>  #    ||||
>  # CPU||||  DURATION                  FUNCTION CALLS
>  # |  ||||   |   |                     |   |   |   |
>   3)  d..1  1.333 us    |        idle_cpu();
>   3)  d.h1              |        tick_check_idle() {
>   3)  d.h1  0.550 us    |          tick_check_oneshot_broadcast();
>   3)  d.h1              |          tick_nohz_stop_idle() {
>   3)  d.h1              |            ktime_get() {
>   3)  d.h1              |              ktime_get_ts() {
> 
> Signed-off-by: Steven Rostedt <rostedt@...dmis.org>


Great!! Thanks a lot!
That was in my todo list :-)

Oh, BTW, what would you think about addding the current->lock_depth
in the latency format? That may help debug the bkl...


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/