linux-kernel - Re: [PATCH 3/3] devmem: remove redundant parameter from do_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252769454.28368.66.camel@desktop>
Date:	Sat, 12 Sep 2009 08:30:54 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>, Avi Kivity <avi@...ranet.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Johannes Berg <johannes@...solutions.net>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] devmem: remove redundant parameter from
 do_write_kmem()

On Sat, 2009-09-12 at 23:20 +0800, Wu Fengguang wrote:
>  static inline ssize_t
> -do_write_kmem(void *p, unsigned long realp, const char __user * buf,
> +do_write_kmem(unsigned long p, const char __user * buf,
>               size_t count, loff_t *ppos)
>  {

There's one style issue in the block above. Could you run your patches
through checkpatch and fix whatever errors it reports?

Daniel



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/