linux-kernel - Re: [RFC PATCH 0/19] A kernel-level configfs enabled generic target engine for Linux v2.6.32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1252723060.28368.48.camel@desktop>
Date:	Fri, 11 Sep 2009 19:37:40 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg KH <greg@...ah.com>,
	Douglas Gilbert <dgilbert@...erlog.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Hannes Reinecke <hare@...e.de>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Mike Christie <michaelc@...wisc.edu>,
	Joel Becker <joel.becker@...cle.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Christoph Hellwig <hch@....de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Florian Haas <florian.haas@...bit.com>,
	Philipp Reisner <philipp.reisner@...bit.com>
Subject: Re: [RFC PATCH 0/19] A kernel-level configfs enabled generic
 target engine for Linux v2.6.32

On Fri, 2009-09-11 at 18:55 -0700, Nicholas A. Bellinger wrote:
> There is cleanup work continuing to make the TCM code to use
> dprintk(),
> and some include cleanups, and other minor fixes.  The code has also
> been run through checkpatch again since the posting in April, and all
> errors have been removed, with the exception of one ConfigFS macro
> define triggering a checkpatch false positive.


One show stopping issue is that your adding new semaphore usage in patch
5 and 16 (and in 16 it's a LOCKED one wtf!!). Which you should not be
doing .. You need to really evaluate the warnings from checkpatch, cause
those still have meaning.. 

It's basically telling you what you should be doing in the warnings..
For instance, don't add new semaphore usage, and it tells you what you
need to be using in place of them.. Also typedefs are frowned upon, so
you could remove those..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/