linux-kernel - Re: [PATCH 2/8] drivers/media/video/uvc: introduce missing kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0909132245220.31000@ask.diku.dk>
Date:	Sun, 13 Sep 2009 22:45:51 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/8] drivers/media/video/uvc: introduce missing kfree

> > -	if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) && query == UVC_GET_DEF)
> > -		return -EIO;
> > +	if ((stream->dev->quirks & UVC_QUIRK_PROBE_DEF) &&
> > +			query == UVC_GET_DEF) {
> > +		ret = -EIO;
> > +		goto out;
> > +	}
> 
> This check can be moved before kmalloc(), removing the need to free memory in 
> case of error.
> 
> Julia, do you want to submit a modified patch or should I do it myself ?

I can do it.  I will send a revised patch shortly.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/