linux-kernel - Re: [PATCH] libata: Add pata_atp867x driver for Artop/Acard ATP867X controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51f3faa70909122250o59fcd174ifee4277ba25a20fe@mail.gmail.com>
Date:	Sat, 12 Sep 2009 23:50:45 -0600
From:	Robert Hancock <hancockrwd@...il.com>
To:	"Jung-Ik (John) Lee" <jilee@...gle.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>,
	Daniel Walker <dwalker@...o99.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, Grant Grundler <grundler@...gle.com>,
	Gwendal Grignou <gwendal@...gle.com>,
	Eric Uhrhane <ericu@...gle.com>
Subject: Re: [PATCH] libata: Add pata_atp867x driver for Artop/Acard ATP867X 
	controllers

On Sat, Sep 12, 2009 at 10:55 PM, Jung-Ik (John) Lee <jilee@...gle.com> wrote:
> I agree in that it's hard to measure/signify the additional overhead,
> since those io insts are already too slow.
> Anyways, the two extra "if"s and one PIO_MASK on every ioread/iowrite
> are pure overhead on top of in/out insts.

I don't think that any platform currently breaks if you use the
readX/writeX instead of ioreadX/iowriteX on iomapped MMIO addresses
(and there's certainly enough code in libata that does this), but the
API definition really expects that you should be using ioread/iowrite
so it would probably be best not to add any more of these..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/