linux-kernel - Re: [PATCH] kgdb: Replace strstr() by strchr() for single-character needles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10f740e80909130040o4c8f89a1y40da5f222f27e0b5@mail.gmail.com>
Date:	Sun, 13 Sep 2009 09:40:03 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	kgdb-bugreport@...ts.sourceforge.net,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kgdb: Replace strstr() by strchr() for single-character 
	needles

On Sat, Sep 12, 2009 at 17:16, Jason Wessel <jason.wessel@...driver.com> wrote:
> I think the patch is fine and I will accept it into the kgdb tree for
> pushing to Linus, but I did have a question.
>
> How did the kgdbts.o end up getting compiled on m68k if there is no kgdb
> support on m68k?

It didn't. I was just grepping for the problematic strstr() case.

> Geert Uytterhoeven wrote:
>> Some versions of gcc replace calls to strstr() with single-character
>> "needle" string parameters by calls to strchr() behind our back.
>> This causes linking errors if strchr() is defined as an inline function
>> in <asm/string.h> (e.g. on m68k, which BTW doesn't have kgdb support).
>>
>> Prevent this by explicitly calling strchr() instead.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> ---
>> This is the single remaining case where strstr() is used with a
>> single-character needle.  Cfr.
>> commit 0d03d59d9b31cd1e33b7e46a80b6fef66244b1f2 ("md: Fix "strchr"
>> [drivers/md/dm-log-userspace.ko] undefined!")
>> commit d8b0fb51ef1563c631d26cb649a5479b5cc4899c ("[PATCH] libertas link error
>> due to gcc `smartness'")

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/