linux-kernel - Re: [PATCH 0/4] compcache: in-memory compressed swapping v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0909131956590.28668@sister.anvils>
Date:	Sun, 13 Sep 2009 20:07:05 +0100 (BST)
From:	Hugh Dickins <hugh.dickins@...cali.co.uk>
To:	Nitin Gupta <ngupta@...are.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ed Tomlinson <edt@....ca>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	linux-mm-cc <linux-mm-cc@...top.org>
Subject: Re: [PATCH 0/4] compcache: in-memory compressed swapping v2

On Sat, 12 Sep 2009, Nitin Gupta wrote:
> On 09/10/2009 03:32 AM, Nitin Gupta wrote:
> > Project home: http://compcache.googlecode.com/
> >
> > * Changelog: v2 vs initial revision
> >   - Use 'struct page' instead of 32-bit PFNs in ramzswap driver and
> >   xvmalloc.
> >     This is to make these 64-bit safe.
> >   - xvmalloc is no longer a separate module and does not export any symbols.
> >     Its compiled directly with ramzswap block driver. This is to avoid any
> >     last bit of confusion with any other allocator.
> >   - set_swap_free_notify() now accepts block_device as parameter instead of
> >     swp_entry_t (interface cleanup).
> >   - Fix: Make sure ramzswap disksize matches usable pages in backing swap
> >   file.
> >     This caused initialization error in case backing swap file had
> >     intra-page
> >     fragmentation.
> 
> Can anyone please review these patches for possible inclusion in 2.6.32?

Sorry, I certainly wouldn't be able to review them for 2.6.32 myself.

Since we're already in the merge window, and this work has not yet
had exposure in mmotm (preferably) or linux-next, I really doubt
anyone should be pushing it for 2.6.32.

I'd be quite glad to see it and experiment with it in mmotm,
so it could go into 2.6.33 if all okay.  And I now fully accept
that the discard/trim situation is so hazy that you are quite
right to be asking for your own well-defined notifier instead.

But I'm not going to pretend to have reviewed it.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/