linux-kernel - Re: recent bdi changes result in WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090914090533.GU14984@kernel.dk>
Date:	Mon, 14 Sep 2009 11:05:33 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
Cc:	dm-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: recent bdi changes result in WARN_ON on luksClose / dm

On Sun, Sep 13 2009, Jens Axboe wrote:
> On Sun, Sep 13 2009, Sebastian Andrzej Siewior wrote:
> > * Jens Axboe | 2009-09-12 21:58:40 [+0200]:
> > 
> > >Don't count this as a real fix, I'll investigate closer on monday. Does
> > >the warning go away with this hack? It'll ensure that pending dirty
> > >inodes are flushed.
> > 
> > That warning goes away but another pops up:
> 
> Oh right, just goes to show that it's doing this backwards. We need the
> umount rwsem for WB_SYNC_ALL. I'll look at this tomorrow.

I think the safest option is to ensure that we just move these entries
to our default bdi, which doesn't go away. This should fix the warning,
can you test whether it works as well?

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index fd93566..27f82dc 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -668,7 +668,17 @@ void bdi_destroy(struct backing_dev_info *bdi)
 {
 	int i;
 
-	WARN_ON(bdi_has_dirty_io(bdi));
+	/*
+	 * Splice our entries to the default_backing_dev_info, if this
+	 * bdi disappears
+	 */
+	if (bdi_has_dirty_io(bdi)) {
+		struct bdi_writeback *dst = &default_backing_dev_info.wb;
+
+		list_splice(&bdi->wb.b_dirty, &dst->b_dirty);
+		list_splice(&bdi->wb.b_io, &dst->b_io);
+		list_splice(&bdi->wb.b_more_io, &dst->b_more_io);
+	}
 
 	bdi_unregister(bdi);
 

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/