linux-kernel - Re: [PATCH v4] ftrace: document basic ftracer/ftracer graph needs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0909141321t515648c7ue0a7d377b99f13f5@mail.gmail.com>
Date:	Mon, 14 Sep 2009 16:21:35 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	rostedt@...dmis.org
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] ftrace: document basic ftracer/ftracer graph needs

On Mon, Sep 14, 2009 at 15:48, Steven Rostedt wrote:
> On Sat, 2009-06-13 at 23:05 -0400, Mike Frysinger wrote:
>> diff --git a/Documentation/trace/ftrace.txt b/Documentation/trace/ftrace.txt
>> index fd9a3e6..95a39fb 100644
>> --- a/Documentation/trace/ftrace.txt
>> +++ b/Documentation/trace/ftrace.txt
>> @@ -27,6 +27,12 @@ disabled, and more (ftrace allows for tracer plugins, which
>>  means that the list of tracers can always grow).
>>
>>
>> +Implementation Details
>> +----------------------
>> +
>> +See ftrace-implementation.txt for details for arch porters and such.
>
> Might want to specify that this is for the function tracer.

well, all of ftrace.txt says "function tracer", so if/when someone
cleans that up, this will get fixed in the process.

>> --- a/kernel/trace/Kconfig
>> +++ b/kernel/trace/Kconfig
>> @@ -11,31 +11,41 @@ config NOP_TRACER
>>
>>  config HAVE_FTRACE_NMI_ENTER
>>       bool
>> +     help
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config HAVE_FUNCTION_TRACER
>>       bool
>> +     help
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config HAVE_FUNCTION_GRAPH_TRACER
>>       bool
>> +     help
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config HAVE_FUNCTION_TRACE_MCOUNT_TEST
>>       bool
>>       help
>> -      This gets selected when the arch tests the function_trace_stop
>> -      variable at the mcount call site. Otherwise, this variable
>> -      is tested by the called function.
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config HAVE_DYNAMIC_FTRACE
>>       bool
>> +     help
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config HAVE_FTRACE_MCOUNT_RECORD
>>       bool
>> +     help
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config HAVE_HW_BRANCH_TRACER
>>       bool
>>
>>  config HAVE_FTRACE_SYSCALLS
>>       bool
>> +     help
>> +       See Documentation/trace/ftrace-implementation.txt
>>
>>  config TRACER_MAX_TRACE
>>       bool
>
> Other than this, it looks good.

so you want me to drop the Kconfig pieces ?  there was discussion in
this thread about why the Kconfig pieces were here ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/