linux-kernel - Re: PATCH] cpuidle: A new variant of the menu governor to boost IO performance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090914223158.60ea33f8@infradead.org>
Date:	Mon, 14 Sep 2009 22:31:58 +0200
From:	Arjan van de Ven <arjan@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, lenb@...nel.org, mingo@...e.hu,
	peterz@...radead.org, yanmin_zhang@...ux.intel.com,
	torvalds@...ux-foundation.org, jens.axboe@...cle.com,
	Tejun Heo <tj@...nel.org>, David Howells <dhowells@...hat.com>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>
Subject: Re: PATCH] cpuidle: A new variant of the menu governor to boost IO
 performance

On Mon, 14 Sep 2009 00:43:01 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> 
> static DEFINE_PER_CPU(struct menu_device, menu_devices);
> 
> in both menu.c and menu-tng.c.
> 
> Despite the `static', the percpu changes in
> 
> commit 7c756e6e19e71f0327760d8955f7077118ebb2b1
> Author:     Tejun Heo <tj@...nel.org>
> AuthorDate: Wed Jun 24 15:13:50 2009 +0900
> Commit:     Tejun Heo <tj@...nel.org>
> CommitDate: Wed Jun 24 15:13:50 2009 +0900
> 
>     percpu: implement optional weak percpu definitions
> 
> are emitting global symbol derived from `menu_devices' and they clash.
> 
> 
> I'll rename menu_devices to fix that up, but we have a problem...

I would consider "static" not working a problem...
yes here it's easy to fix, but it's not nice if you can't make .c file
private..


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/