linux-kernel - Re: [Resend][PATCH 2/2] PCI PM: Return error codes from pci_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090914134210.3376e0f7@jbarnes-g45>
Date:	Mon, 14 Sep 2009 13:42:10 -0700
From:	Jesse Barnes <jesse.barnes@...el.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Linux PCI <linux-pci@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>
Subject: Re: [Resend][PATCH 2/2] PCI PM: Return error codes from
 pci_pm_resume()

On Wed, 9 Sep 2009 23:51:27 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:

> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Currently pci_pm_resume() always returns 0, which makes the error
> variable defined in there a bit pointless.  Make pci_pm_resume()
> return error codes obtained from drivers' callbacks.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
>  drivers/pci/pci-driver.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/drivers/pci/pci-driver.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/pci-driver.c
> +++ linux-2.6/drivers/pci/pci-driver.c
> @@ -689,7 +689,7 @@ static int pci_pm_resume(struct device *
>  		pci_pm_reenable_device(pci_dev);
>  	}
>  
> -	return 0;
> +	return error;
>  }
>  
>  #else /* !CONFIG_SUSPEND */
> 

Applied these two, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/