[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1252915048.6052.249.camel@localhost.localdomain>
Date: Mon, 14 Sep 2009 08:57:28 +0100
From: Steven Whitehouse <swhiteho@...hat.com>
To: Daniel Walker <dwalker@...o99.com>
Cc: linux-kernel@...r.kernel.org, cluster-devel@...hat.com
Subject: Re: GFS2: Pre-pull patch posting
Hi,
On Thu, 2009-09-10 at 07:46 -0700, Daniel Walker wrote:
> On Thu, 2009-09-10 at 12:27 +0100, Steven Whitehouse wrote:
> > As merge time is approaching, here is the current content of the
> > GFS2 -nmw git tree. I'm not expecting to take any more patches
> > now for the current merge window unless any last minute bugs
> > are discovered.
> >
> > There is not a huge amount new this time. Some extra context for
> > uevent messages, better error handling during block allocation,
> > and a clean up of extended attribute support. There is still more
> > to do on the extended attribute side of things, but this is a good
> > start I think.
> >
> > There are a few bug fixes as well. Once these patches are merged
> > I'm intending to start off the next -nmw tree with a patch to
> > remove some of the (now unused) sysfs files as per the message
> > on cluster-devel a few weeks back.
>
> This patch set has a couple of checkpatch issues..
>
> Patch 3,
>
> ERROR: code indent should use tabs where possible
> #83: FILE: fs/gfs2/rgrp.c:1466:
> +^I (unsigned long long)rgd->rd_addr);$
>
>
Now fixed in the latest -nmw tree.
> Patch 11,
>
> ERROR: trailing whitespace
> #741: FILE: fs/gfs2/eattr.c:565:
> +^Iif (size) $
>
> and patch 12,
>
> ERROR: trailing whitespace
> #2349: FILE: fs/gfs2/xattr.c:565:
> +^Iif (size) $
>
This is the same line of code. There is no need to report it twice.
> ERROR: space required after that ',' (ctx:VxV)
> #2833: FILE: fs/gfs2/xattr.c:1049:
> + return ea_remove_unstuffed(ip, el->el_bh, el->el_ea, el->el_prev,0);
>
> ERROR: code indent should use tabs where possible
> #3370: FILE: fs/gfs2/xattr.h:22:
> + (sizeof(__be64) * (ea)->ea_num_ptrs)), 8)$
>
> Could you correct these prior to you pull request?
>
> Daniel
>
The above two are both part of the context rather than something I've
added. I've fixed them anyway though,
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists