| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1253042322.30165.52.camel@dax.rpnet.com> Date: Tue, 15 Sep 2009 20:18:42 +0100 From: Richard Purdie <rpurdie@...ys.net> To: Matthew Garrett <mjg@...hat.com> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] backlight: Provide two stage registration On Tue, 2009-09-15 at 17:19 +0100, Matthew Garrett wrote: > The backlight class currently allocates and registers a backlight device > in a single function, making it impossible for certain backlight parameters > to be set before the device becomes visible to userspace. This can cause > problems if userspace wins the race and manages to read any of these values > before they've been set, and also makes it harder to extend information > that we may wish to provide to the rest of the kernel at registration time. > > This patch breaks the register and unregister functions into two, > separating allocation and registration. The old functions are left to ease > transition. I understand the problem but the second patch in this series bothers me - an additional 300 lines of error handling in each driver. Could we not pass an optional pointer to a properties structure to create the backlight with instead or find a better way to solve this? Cheers, Richard -- Richard Purdie Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists