linux-kernel - Re: [patch 1/5] fs: make use of rcu helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090915193141.GT23126@kernel.dk>
Date:	Tue, 15 Sep 2009 21:31:41 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	npiggin@...e.de
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 1/5] fs: make use of rcu helpers

On Wed, Sep 16 2009, npiggin@...e.de wrote:
> list_add_tail_rcu contains required barriers.

Thanks, applied as well.

> 
> Signed-off-by: Nick Piggin <npiggin@...e.de>
> ---
>  fs/fs-writeback.c |    5 -----
>  1 file changed, 5 deletions(-)
> 
> Index: linux-2.6/fs/fs-writeback.c
> ===================================================================
> --- linux-2.6.orig/fs/fs-writeback.c
> +++ linux-2.6/fs/fs-writeback.c
> @@ -152,11 +152,6 @@ static void bdi_queue_work(struct backin
>  		atomic_set(&work->pending, bdi->wb_cnt);
>  		BUG_ON(!bdi->wb_cnt);
>  
> -		/*
> -		 * Make sure stores are seen before it appears on the list
> -		 */
> -		smp_mb();
> -
>  		spin_lock(&bdi->wb_lock);
>  		list_add_tail_rcu(&work->list, &bdi->work_list);
>  		spin_unlock(&bdi->wb_lock);
> 
> 

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/