linux-kernel - Re: [RFC][PATCH] LED driver for Intel NAS SS4200 series

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2009 22:59:04 +0100
From:	Richard Purdie <rpurdie@...ys.net>
To:	Dave Hansen <dave@...1.net>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [RFC][PATCH] LED driver for Intel NAS SS4200 series

On Tue, 2009-09-15 at 14:52 -0700, Dave Hansen wrote:
> On Tue, 2009-09-15 at 22:38 +0100, Richard Purdie wrote:
> > At a quick review this looks good. One question: These LEDs appear to be
> > attached to generic GPIOs on a southbridge that is probably in other
> > devices? If so, how do we know they're connected to LEDs? Do we need to
> > add some further check of what kind of device we're running on?
> 
> Good question.  I assumed that the PCI ids were a sufficient enough
> check.  But, you're right, those PCI ids look like they're for all ICH7
> boards.
> 
> Any suggestions on what kinds of checks we might add?  This thing acts
> like a pretty generic normal PC.  Do any of the other LED drivers have a
> similar problem?

Yes. In this case can we check for a set of DMI IDs? The clevo mail
driver has an example of that...

Cheers,

Richard

-- 
Richard Purdie
Intel Open Source Technology Centre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/