linux-kernel - Re: [RFC/PATCH] SLQB: Mark the allocator as broken PowerPC and S390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253084468.6749.27.camel@penberg-laptop>
Date:	Wed, 16 Sep 2009 10:01:08 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	cl@...ux-foundation.org, heiko.carstens@...ibm.com, mingo@...e.hu,
	npiggin@...e.de, sachinp@...ibm.com
Subject: Re: [RFC/PATCH] SLQB: Mark the allocator as broken PowerPC and S390

Hi David,

On Wed, 16 Sep 2009, Pekka Enberg wrote:
> > The SLQB allocator is known to be broken on certain PowerPC and S390
> > configurations. Disable the allocator in Kconfig for those architectures
> > until the issues are resolved.
> > 
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Christoph Lameter <cl@...ux-foundation.org>
> > Cc: Heiko Carstens <heiko.carstens@...ibm.com>
> > Cc: Ingo Molnar <mingo@...e.hu>
> > Cc: Nick Piggin <npiggin@...e.de>
> > Cc: Sachin Sant <sachinp@...ibm.com>
> > Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
> > ---
> >  init/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/init/Kconfig b/init/Kconfig
> > index c0d8a47..aaeddeb 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1033,6 +1033,7 @@ config SLUB
> >  
> >  config SLQB
> >  	bool "SLQB (Queued allocator)"
> > +	depends on !PPC && !S390
> >  	help
> >  	  SLQB is a proposed new slab allocator.
> >  

On Tue, 2009-09-15 at 23:55 -0700, David Rientjes wrote:
> I think this should be (!PPC && !S390) || EXPERIMENTAL so that it can 
> still be enabled for debugging and development.

Everybody enables EXPERIMENTAL so that seems pointless. Developers can
hack Kconfig locally, no?

On Tue, 2009-09-15 at 23:55 -0700, David Rientjes wrote:
> Is this in preparation for slqb inclusion as a non-default slab
> allocator in 2.6.32?  2.6.33?

Non-default for 2.6.32.

			Pekka

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/