linux-kernel - Re: [PATCH 05/11] Assign bdi in super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090916130040.GM23126@kernel.dk>
Date:	Wed, 16 Sep 2009 15:00:40 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	chris.mason@...cle.com, hch@...radead.org, tytso@....edu,
	akpm@...ux-foundation.org, trond.myklebust@....uio.no
Subject: Re: [PATCH 05/11] Assign bdi in super_block

On Wed, Sep 16 2009, Jan Kara wrote:
> On Tue 15-09-09 20:16:51, Jens Axboe wrote:
> > We do this automatically in get_sb_bdev() from the set_bdev_super()
> > callback. Filesystems that have their own private backing_dev_info
> > must assign that in ->fill_super().
> > 
> > Note that ->s_bdi assignment is required for proper writeback!
> > 
> > Acked-by: Christoph Hellwig <hch@...radead.org>
> > Signed-off-by: Jens Axboe <jens.axboe@...cle.com>
> > ---
> >  fs/btrfs/disk-io.c |    1 +
> >  fs/fuse/inode.c    |    2 ++
> >  fs/super.c         |    6 ++++++
> >  fs/sync.c          |    9 ++++++++-
> >  fs/ubifs/super.c   |    1 +
> >  include/linux/fs.h |    1 +
> >  6 files changed, 19 insertions(+), 1 deletions(-)
>   I think we agreed that NFS needs to assign it's private BDI to sb->s_bdi,
> didn't we? From Tronds comment, that should be enough.

Oops indeed, added that one-liner now.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/