linux-kernel - Re: 2.6.31-rc5 regression: hd don't show up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AB04B39.7030907@kernel.org>
Date:	Wed, 16 Sep 2009 11:19:37 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Tim Blechmann <tim@...ngt.org>
CC:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: 2.6.31-rc5 regression: hd don't show up

Hello,

Tim Blechmann wrote:
> with this patch, i could reproduce it again on the first boot. bootlog
> attached.

Thanks a lot for testing.  The offending commit is 816ab897.

commit 816ab89782ac139a8b65147cca990822bb7e8675
Author: Tejun Heo <tj@...nel.org>
Date:   Wed Oct 22 00:31:34 2008 +0900

    libata: set device class to NONE if phys_offline

    Reset methods don't have access to phys link status for slave links
    and may incorrectly indicate device presence causing unnecessary probe
    failures for unoccupied links.  This patch clears device class to NONE
    during post-reset processing if phys link is offline.

    As on/offlineness semantics is strictly defined and used in multiple
    places by the core layer, this won't change behavior for drivers which
    don't use slave links.

    Signed-off-by: Tejun Heo <tj@...nel.org>
    Signed-off-by: Jeff Garzik <jgarzik@...hat.com>

The problem is that I don't really remember why I added this one back
then.  This is incorrect because the condition should be dealt with
later in the reset logic.  That didn't work quite as expected and I
ended up adding the above to work around that and it turned out wrong.
I'll dig deeper and find out what was the problem back then.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/