linux-kernel - Re: [PATCH v4] input/keyboard: new OpenCores Keyboard Controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Sep 2009 23:57:32 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Javier Herrero <jherrero@...istemas.es>,
	Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH v4] input/keyboard: new OpenCores Keyboard Controller 
	driver

On Tue, Sep 15, 2009 at 23:45, Dmitry Torokhov wrote:
> On Tue, Sep 15, 2009 at 10:00:40PM -0400, Mike Frysinger wrote:
>> +
>> +static int __devexit opencores_kbd_remove(struct platform_device *pdev)
>> +{
>> +     struct opencores_kbd *opencores_kbd = platform_get_drvdata(pdev);
>> +
>> +     free_irq(opencores_kbd->irq, opencores_kbd);
>> +
>> +     input_unregister_device(opencores_kbd->input);
>> +     kfree(opencores_kbd);
>
> You need to do iounmap and free the memory region here as well.

ugh, i remembered i would have to do this while writing the initial
code, but forgot while double checking the different error paths
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/