linux-kernel - Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd memory:" message on h3800, m68knommu and microblaze.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AB1E78D.3070007@snapgear.com>
Date:	Thu, 17 Sep 2009 17:38:53 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
CC:	linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...inux.org>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	microblaze-uclinux@...e.uq.edu.au
Subject: Re: [PATCH] Actually show KiB rather than pages in "Freeing initrd
 memory:" message on h3800, m68knommu and microblaze.

Hi Lennart,

Lennart Sorensen wrote:
> Fix "Freeing initrd memory:" message on h3800, m68knommu and microblaze
> to show kilobytes as claimed rather than number of pages.
> 
> Signed-off-by: Lennart Sorensen <lsorense@...lub.uwaterloo.ca>

Looks ok to me. I can take and push the m68knommu part separately.
Or if Andrew wants to take it all as one, here is an:

Acked-by: Greg Ungerer <gerg@...inux.org>


Regards
Greg


> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
> index 9942f24..3342f49 100644
> --- a/arch/h8300/mm/init.c
> +++ b/arch/h8300/mm/init.c
> @@ -170,7 +170,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk ("Freeing initrd memory: %dk freed\n", pages);
> +	printk ("Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> diff --git a/arch/m68knommu/mm/init.c b/arch/m68knommu/mm/init.c
> index b1703c6..f3236d0 100644
> --- a/arch/m68knommu/mm/init.c
> +++ b/arch/m68knommu/mm/init.c
> @@ -162,7 +162,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk (KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index f207f1a..ed5f96b 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -180,7 +180,7 @@ void free_initrd_mem(unsigned long start, unsigned long end)
>  		totalram_pages++;
>  		pages++;
>  	}
> -	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages);
> +	printk(KERN_NOTICE "Freeing initrd memory: %dk freed\n", pages * (PAGE_SIZE / 1024));
>  }
>  #endif
>  
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/