linux-kernel - Re: rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090917181133.GA5797@sucs.org>
Date:	Thu, 17 Sep 2009 19:11:33 +0100
From:	Andrew Price <andy@...rewprice.me.uk>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Ivo van Doorn <ivdoorn@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’

On Thu, Sep 17, 2009 at 01:23:59PM -0400, John W. Linville wrote:
> On Thu, Sep 17, 2009 at 04:41:39PM +0100, Andrew Price wrote:
> > Hi Ivo,
> > 
> > Apologies if this has already been reported. Building today's mainline
> > kernel (ab86e5) I'm seeing this error:
> > 
> > drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_rxdone’:
> > drivers/net/wireless/rt2x00/rt2x00dev.c:405: warning: passing argument 3 of ‘rt2x00crypto_rx_insert_iv’ makes integer from pointer without a cast
> > drivers/net/wireless/rt2x00/rt2x00dev.c:405: error: too few arguments to function ‘rt2x00crypto_rx_insert_iv’
> 
> Strange...I don't see this warning.  Are you sure you have a clean checkout?

I double-checked:

- git status returned no changes
- git clean -fqdx
- ccache -C
- Retried the build

and still got the same error. Is this something to do with the second
definition of rt2x00crypto_rx_insert_iv still having an l2pad parameter...

This (untested) patch fixes the build for me:

--

diff --git a/drivers/net/wireless/rt2x00/rt2x00lib.h b/drivers/net/wireless/rt2x00/rt2x00lib.h
index 5462cb5..567f029 100644
--- a/drivers/net/wireless/rt2x00/rt2x00lib.h
+++ b/drivers/net/wireless/rt2x00/rt2x00lib.h
@@ -380,7 +380,7 @@ static inline void rt2x00crypto_tx_insert_iv(struct sk_buff *skb,
 {
 }
 
-static inline void rt2x00crypto_rx_insert_iv(struct sk_buff *skb, bool l2pad,
+static inline void rt2x00crypto_rx_insert_iv(struct sk_buff *skb,
 					     unsigned int header_length,
 					     struct rxdone_entry_desc *rxdesc)
 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/