linux-kernel - Re: free_initrd_mem() corrups mm state on m68knommu.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4AB2C983.3000808@snapgear.com>
Date:	Fri, 18 Sep 2009 09:42:59 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
CC:	linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...inux.org>,
	uclinux-dev@...inux.org
Subject: Re: free_initrd_mem() corrups mm state on m68knommu.

Hi Lennart,

Lennart Sorensen wrote:
> On Thu, Sep 17, 2009 at 05:34:37PM +1000, Greg Ungerer wrote:
>> Hi Lennart,
>>
>> Lennart Sorensen wrote:
>>> On Tue, Sep 15, 2009 at 05:49:59PM -0400, Lennart Sorensen wrote:
...
>>> OK, seems the issue was that setup.c wasn't flagging the initrd memory
>>> range as 'reserve_bootmem' which caused extra memory to be forced into
>>> the mm state when it was later freed.  I guess one has to be very careful
>>> with what patches one finds lying around the internet (in this case the
>>> uboot bootargs patch for m68knommu that we found somewhere).
>>>
>>> Seems to work great now, and I finally made sense of how the bootmem
>>> map is passed and what is going where.  It all makes sense now.
>> Can you send a patch for it?
>> I can push it to mainline of it looks reasonable.
> 
> Well it's a patch ontop of another patch that isn't in mainline.
> The other patch is one that adds support for uboot passing kernel command
> line arguments.  Want that one too?  We find it to be rather useful.

Sure, send them both.

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/