linux-kernel - Re: [PATCH] Remove broken by design and by implementation devtmpfs maintenance disaster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1k4zw4f0f.fsf@fess.ebiederm.org>
Date:	Fri, 18 Sep 2009 05:24:32 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Greg KH <greg@...ah.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH] Remove broken by design and by implementation devtmpfs maintenance disaster

Greg KH <greg@...ah.com> writes:

> I'm really sorry, but I know of no existing bugs in this code.
> Seriously, I thought we addressed everything that was pointed out.

Then please sober up and open your eyes.  Bugs are not hard to find.
And I pointed out about 5 of them at the beginning of my message.

The simplest and most trivial of them is that the error handling
path is device_add was not updated to remove the devtmpfs node
if it was not created.

I find it maximally offensive that when I try and give constructive
criticism that I am either written off or told that my patches will
be summarily dropped.

The code I think is fixable.  You I have much less hope for.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/