linux-kernel - [PATCH] i2c: Move i2c request_irq so that it occurs after iop3xx_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Sep 2009 09:51:11 -0400
From:	Jon Ringle <jon@...gle.org>
To:	"Ben Dooks (embedded platforms)" <ben-linux@...ff.org>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	Jon Ringle <jon@...gle.org>
Subject: [PATCH] i2c: Move i2c request_irq so that it occurs after iop3xx_i2c_enable

If there is a pending i2c interrupt present before i2c-iop3xx initialization
then it must be cleared first before registering irq handler. Otherwise,
a hung system due to an unhandled interrupt loop may occur.

Signed-off-by: Jon Ringle <jon@...gle.org>

---
 drivers/i2c/busses/i2c-iop3xx.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/i2c/busses/i2c-iop3xx.c b/drivers/i2c/busses/i2c-iop3xx.c
index a75c75e..e6dc46d 100644
--- a/drivers/i2c/busses/i2c-iop3xx.c
+++ b/drivers/i2c/busses/i2c-iop3xx.c
@@ -471,14 +471,6 @@ iop3xx_i2c_probe(struct platform_device *pdev)
 		ret = -ENXIO;
 		goto unmap;
 	}
-	ret = request_irq(irq, iop3xx_i2c_irq_handler, 0,
-				pdev->name, adapter_data);
-
-	if (ret) {
-		ret = -EIO;
-		goto unmap;
-	}
-
 	memcpy(new_adapter->name, pdev->name, strlen(pdev->name));
 	new_adapter->owner = THIS_MODULE;
 	new_adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
@@ -497,6 +489,14 @@ iop3xx_i2c_probe(struct platform_device *pdev)
 	iop3xx_i2c_reset(adapter_data);
 	iop3xx_i2c_enable(adapter_data);
 
+	ret = request_irq(irq, iop3xx_i2c_irq_handler, 0,
+				pdev->name, adapter_data);
+
+	if (ret) {
+		ret = -EIO;
+		goto unmap;
+	}
+
 	platform_set_drvdata(pdev, new_adapter);
 	new_adapter->algo_data = adapter_data;
 
-- 
tg: (74fca6a..) t/isc-31/i2c-request_irq-iop3xx_i2c_enable-reorder (depends on: b2.6.31.y)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/