linux-kernel - Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of kernel/rcutree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253293100.7060.46.camel@desktop>
Date:	Fri, 18 Sep 2009 09:58:20 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org,
	dvhltc@...ibm.com, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu
Subject: Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of
 kernel/rcutree_plugin.h

On Fri, 2009-09-18 at 09:50 -0700, Paul E. McKenney wrote:

> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index 2b996c3..a2d586c 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -117,9 +117,9 @@ static void rcu_preempt_note_context_switch(int cpu)
>  		 * on line!
>  		 */
>  	    	WARN_ON_ONCE((rdp->grpmask & rnp->qsmaskinit) == 0);
> -		phase = !(rnp->qsmask & rdp->grpmask) ^ (rnp->gpnum & 0x1);
> +	    	WARN_ON_ONCE(!list_empty(&t->rcu_node_entry));
> +		phase = (rnp->gpnum + !(rnp->qsmask & rdp->grpmask)) & 0x1;
>  		list_add(&t->rcu_node_entry, &rnp->blocked_tasks[phase]);
> -		smp_mb();  /* Ensure later ctxt swtch seen after above. */
>  		spin_unlock_irqrestore(&rnp->lock, flags);
>  	}

ERROR: code indent should use tabs where possible
#149: FILE: kernel/rcutree_plugin.h:120:
+^I    ^IWARN_ON_ONCE(!list_empty(&t->rcu_node_entry));$


One funny indent in the line above.. If your intending for Ingo to take
this he might just fix it on apply ..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/