lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1253296441.7060.49.camel@desktop>
Date:	Fri, 18 Sep 2009 10:54:01 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Lennart Sorensen <lsorense@...lub.uwaterloo.ca>
Cc:	linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...inux.org>,
	uclinux-dev@...inux.org
Subject: Re: [PATCH] Add uboot commandline argument passing support to
 m68knommu (Try #2)

On Fri, 2009-09-18 at 13:49 -0400, Lennart Sorensen wrote:
> On Fri, Sep 18, 2009 at 09:39:04AM -0700, Daniel Walker wrote:
> > You have a couple of various checkpatch errors in this patch. We use
> > scripts/checkpatch.pl to check for code style issues. Could you run that
> > on your patch and fix any errors it finds? A couple are whitespace
> > related and you can use scripts/cleanpatch or scripts/cleanfile to
> > remove whitespace (so I hear. I've never run those scripts personally)
> 
> Oh dear.  I guess the original patch was a bit messy then.  OK here we
> go again with a checkpatch approved patch.

Much better, thanks for doing that..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ