linux-kernel - Re: [PATCH] nfs: fix bdi_unregister() before sb kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090918202245.GR23126@kernel.dk>
Date:	Fri, 18 Sep 2009 22:22:45 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Trond Myklebust <trond.myklebust@....uio.no>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfs: fix bdi_unregister() before sb kill

On Fri, Sep 18 2009, Peter Zijlstra wrote:
> On Fri, 2009-09-18 at 20:32 +0200, Jens Axboe wrote:
> > Peter, if you have
> > the time, it would be nice if you could check whether this one works for
> > you too.
> 
> Doesn't make my machine happy :/

That looks like a double register. Irk, I see what it is... Can you try
this additional patch?

diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index 712950d..f722de1 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2008,14 +2008,14 @@ struct nfs_sb_mountdata {
 	int mntflags;
 };
 
-static int nfs_bdi_register(struct nfs_server *server)
+static int nfs_bdi_register(struct nfs_server *server, dev_t dev)
 {
 	struct backing_dev_info *bdi = &server->backing_dev_info;
 	int err;
 
 	err = bdi_init(bdi);
 	if (!err) {
-		err = bdi_register_dev(bdi, server->s_dev);
+		err = bdi_register_dev(bdi, dev);
 		if (!err)
 			return 0;
 	}
@@ -2030,7 +2030,7 @@ static int nfs_set_super(struct super_block *s, void *data)
 	struct nfs_server *server = sb_mntdata->server;
 	int ret;
 
-	ret = nfs_bdi_register(server);
+	ret = nfs_bdi_register(server, s->s_dev);
 	if (ret)
 		return ret;
 

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/