linux-kernel - Re: [PATCH] nfs: fix bdi_unregister() before sb kill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090918204409.GV23126@kernel.dk>
Date:	Fri, 18 Sep 2009 22:44:09 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Trond Myklebust <trond.myklebust@....uio.no>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfs: fix bdi_unregister() before sb kill

On Fri, Sep 18 2009, Peter Zijlstra wrote:
> On Fri, 2009-09-18 at 22:22 +0200, Jens Axboe wrote:
> > On Fri, Sep 18 2009, Peter Zijlstra wrote:
> > > On Fri, 2009-09-18 at 20:32 +0200, Jens Axboe wrote:
> > > > Peter, if you have
> > > > the time, it would be nice if you could check whether this one works for
> > > > you too.
> > > 
> > > Doesn't make my machine happy :/
> > 
> > That looks like a double register. Irk, I see what it is... Can you try
> > this additional patch?
> 
> Still deeply unhappy,..
> 
> 1) double bdi registation
> 2) lockdep splat on bdi registration
> 3) NULL ptr deref on netfs automount
> 
> Also note the lockdep splat which I think is caused by these patches..

Sigh, I guess no love for me tonight. OK thanks for testing Peter, I
guess a real tested fix will have to wait for me to get behind the test
box.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/