linux-kernel - Re: [PATCH v3] gpio: add Intel Moorestown Platform Langwell chip gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090917203826.e083746d.akpm@linux-foundation.org>
Date:	Thu, 17 Sep 2009 20:38:26 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alek Du <alek.du@...el.com>
Cc:	"david-b@...bell.net" <david-b@...bell.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Russell King <rmk@....linux.org.uk>
Subject: Re: [PATCH v3] gpio: add Intel Moorestown Platform Langwell chip
 gpio driver

On Fri, 18 Sep 2009 09:18:44 +0800 Alek Du <alek.du@...el.com> wrote:

> Sorry for the inconvenience. I do not have SPARC64 build env., but I think this patch will fix the build issue, I should include <linux/irq.h> by explicit.
> 
> >From 5f0f166b37c4313c27de32f6f200bbd0656603b7 Mon Sep 17 00:00:00 2001
> From: Alek Du <alek.du@...el.com>
> Date: Fri, 18 Sep 2009 09:09:19 +0800
> Subject: [PATCH] gpio: Fix Langwell gpio driver build error
> 
> Need to include <linux/irq.h> directly ...
> 
> Signed-off-by: Alek Du <alek.du@...el.com>
> ---
>  drivers/gpio/langwell_gpio.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/langwell_gpio.c b/drivers/gpio/langwell_gpio.c
> index e100583..10a1172 100644
> --- a/drivers/gpio/langwell_gpio.c
> +++ b/drivers/gpio/langwell_gpio.c
> @@ -27,6 +27,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/init.h>
>  #include <linux/io.h>
> +#include <linux/irq.h>
>  #include <linux/gpio.h>
>  
>  struct lnw_gpio_register {
	
include/linux/irq.h says

/*
 * Please do not include this file in generic code.  There is currently
 * no requirement for any architecture to implement anything held
 * within this file.
 *
 * Thanks. --rmk
 */

but

y:/usr/src/linux-2.6.31> grep -rl 'linux/irq.h' drivers | wc -l
101

Russell, is that rule no longer true?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/