linux-kernel - Re: microblaze: commit 95521585 breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 19 Sep 2009 11:07:08 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	John Williams <john.williams@...alogix.com>
Cc:	Michal Simek <michal.simek@...alogix.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: microblaze: commit 95521585 breakage

On Thu, Sep 17, 2009 at 03:46:26PM +1000, John Williams wrote:
> Hi Sam, Michal,
> 
> Your MicroBlaze arch makefile cleanup commit
> 9552158573f847aa429334bb97995bb290bb4b0d had a rather unfortunate
> error in it:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=950b260ed21fdb6fa5f18485dabb0b03488431fa
> 
> You intended to change CFLAGS_KERNEL to KBUILD_CFLAGS, but instead
> changed CFLAGS_KERNEL to KBUILD_KERNEL.
> 
> The result?  No CPU feature optimisations across the entire MicroBlaze
> kernel build :(
> 
> The fix is trivial - may I leave it to you to resolve and merge as
> soon as possible?  This is a pretty serious performance regression.

Agree with the analysis of John.

Michael - I leave it to you to fix it up.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/