linux-kernel - Re: [PATCH 7/8] perf: Add a perf record --timechart option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090919094452.GA2295@elte.hu>
Date:	Sat, 19 Sep 2009 11:44:52 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, fweisbec@...il.com
Subject: Re: [PATCH 7/8] perf: Add a perf record --timechart option


* Arjan van de Ven <arjan@...radead.org> wrote:

> On Mon, 14 Sep 2009 10:06:00 +0200
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Sat, 2009-09-12 at 13:06 +0200, Arjan van de Ven wrote:
> > > This patch adds a "perf record --timechart" option, to make it easy
> > > to capture traces for use by the timechart tool.
> > 
> > Would it perhaps make sense to make that:
> > 
> >  perf timechart record
> 
> well yes, but it would just be an alias for the former, since it's the 
> record code that has to do the recording... and that's a rather 
> obscene layering violation in how perf is set up I think.

No, please do it like 'perf sched record' does - it constructs an 
argument list of pre-cooked options. See builtin-sched.c's record_args[] 
array.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/