linux-kernel - Re: [PATCH] Fix fn-key release events for Samsung Q320 laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253366458.6699.51.camel@desktop>
Date:	Sat, 19 Sep 2009 06:20:58 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Nick Gasson <nick@...kg.me.uk>
Cc:	linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com
Subject: Re: [PATCH] Fix fn-key release events for Samsung Q320 laptop

On Sat, 2009-09-19 at 08:20 +0100, Nick Gasson wrote:
> This adds a workaround for the missing fn-key release
> events on Samsung Q320 and similar laptops.
> 
> Tested extensively on my own laptop.
> 
> Signed-off-by: Nick Gasson <nick@...kg.me.uk>
> ---
>   drivers/input/keyboard/atkbd.c |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index c9523e4..56a6ffa 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1630,6 +1630,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
>                  .driver_data = atkbd_samsung_forced_release_keys,
>          },
>          {
> +               .ident = "Samsung Q320/P320",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),

Your patch is whitespace damaged .. All the tabs have been removed from
your code, and the context code in the patch. That usually means the
patch can't be applied .. It can happen when you X copy&paste the patch
into an email. I'd use git-format-patch and git-send-email (since your
using git anyway..)

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/