| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 19 Sep 2009 15:08:39 -0400 From: Mike Frysinger <vapier.adi@...il.com> To: Arnd Bergmann <arnd@...db.de> Cc: linux-kernel@...r.kernel.org, uclinux-dist-devel@...ckfin.uclinux.org, Michal Simek <monstr@...str.eu>, Paul Mundt <lethal@...ux-sh.org> Subject: Re: [PATCH 05/17] Blackfin: convert to generic checksum code On Tue, Jun 23, 2009 at 17:14, Arnd Bergmann wrote: > On Friday 19 June 2009, Mike Frysinger wrote: >> > >> > sounds like a good idea. >> >> how about the attached > > Mostly good, but needs some improvements. At least it helped me > track down the last problem. > >> > lib/checksum.c: Fix another endianess bug >> >> hrm, still not quite :/ >> >> the attached test code shows failures in every case > > When I tried running it on x86-64, it only showed failures for > numbers 1, 2 and 4. I fixed them with this patch: > --- > lib/checksum: fix one more thinko > > When do_csum gets unaligned data, we really need to treat > the first byte as an even byte, not an odd byte, because > we swap the two halves later. > > Found by Mike's checksum-selftest module. > > Reported-by: Mike Frysinger <vapier.adi@...il.com> > Signed-off-by: Arnd Bergmann <arnd@...db.de> shouldnt this fix have been in 2.6.31 ? doesnt seem to be even in latest git ... -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists