linux-kernel - Re: [PATCH] kaweth: Fix memory leak in kaweth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200909192119.37988.oliver@neukum.org>
Date:	Sat, 19 Sep 2009 21:19:37 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Kevin Cernekee <cernekee@...il.com>
Cc:	"Greg Kroah-Hartman" <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] kaweth: Fix memory leak in kaweth_control()

Am Samstag, 19. September 2009 03:43:30 schrieb Kevin Cernekee:
> kaweth_control() never frees the buffer that it allocates for the USB
> control message.  Test case:
>
> while :; do ifconfig eth2 down ; ifconfig eth2 up ; done
>
> This is a tiny buffer so it is a slow leak.  If you want to speed up the
> process, you can change the allocation size to e.g. 16384 bytes, and it
> will consume several megabytes within a few minutes.

You are right, the patch is correct. But it has to go to netdev, as it
is for a network driver. Please resend it and add
Acked-by: Oliver Neukum <oliver@...kum.org>

Greg, it should go into stable, too.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/