linux-kernel - Re: [patch] x86, apic: use logical flat on intel with <= 8 logical cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253326790.6699.38.camel@desktop>
Date:	Fri, 18 Sep 2009 19:19:50 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	tglx@...utronix.de, hpa@...or.com, mingo@...e.hu,
	yinghai@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] x86, apic: use logical flat on intel with <= 8 logical
 cpus

On Fri, 2009-09-18 at 19:05 -0700, Suresh Siddha wrote:
> +               switch (boot_cpu_data.x86_vendor) {
> +                       case X86_VENDOR_INTEL:
> +                               if (num_processors > 8)
> +                                       apic = &apic_physflat;
> +                               break;
> +                       case X86_VENDOR_AMD:
> +                               if (max_physical_apicid >= 8)
> +                                       apic = &apic_physflat;
> +               }

There are a couple of checkpatch issues in this patch .. Could you run
it through and fix the errors that show up.. One is that you need 1 less
tab for the code inside the switch statement .. You have another switch
statement in apic.c that needs similar attention .

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/