linux-kernel - Re: [PATCH] fs: Fix busyloop in wb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090920174356.GA16919@duck.suse.cz>
Date:	Sun, 20 Sep 2009 19:43:56 +0200
From:	Jan Kara <jack@...e.cz>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Jan Kara <jack@...e.cz>,
	"jens.axboe@...cle.com" <jens.axboe@...cle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"chris.mason@...cle.com" <chris.mason@...cle.com>
Subject: Re: [PATCH] fs: Fix busyloop in wb_writeback()

On Sun 20-09-09 10:35:28, Wu Fengguang wrote:
> On Thu, Sep 17, 2009 at 01:22:48AM +0800, Jan Kara wrote:
> > If all inodes are under writeback (e.g. in case when there's only one inode
> > with dirty pages), wb_writeback() with WB_SYNC_NONE work basically degrades
> > to busylooping until I_SYNC flags of the inode is cleared. Fix the problem by
> > waiting on I_SYNC flags of an inode on b_more_io list in case we failed to
> > write anything.
> 
> Sorry, I realized that inode_wait_for_writeback() waits for I_SYNC.
> But inodes in b_more_io are not expected to have I_SYNC set. So your
> patch looks like a big no-op?
  Hmm, I don't think so. writeback_single_inode() does:
        if (inode->i_state & I_SYNC) {
                /*
                 * If this inode is locked for writeback and we are not
                 * doing
                 * writeback-for-data-integrity, move it to b_more_io so
                 * that
                 * writeback can proceed with the other inodes on s_io.
                 *
                 * We'll have another go at writing back this inode when we
                 * completed a full scan of b_io.
                 */
                if (!wait) {
                        requeue_io(inode);
                        return 0;
                }

  So when we see inode under writeback, we put it to b_more_io. So I think
my patch really fixes the issue when two threads are racing on writing the
same inode.

> The busy loop does exists, when bdi is congested.
> In this case, write_cache_pages() will refuse to write anything,
> we used to be calling congestion_wait() to take a breath, but now
> wb_writeback() purged that call and thus created a busy loop.
  I don't think congestion is an issue here. The device needen't be
congested for the busyloop to happen.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/