linux-kernel - Re: [PATCH] perf_counter/powerpc: Fix compilation after perf_counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090921073848.GA4649@osiris.boeblingen.de.ibm.com>
Date:	Mon, 21 Sep 2009 09:38:48 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"Metzger, Markus T" <markus.t.metzger@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sachin Sant <sachinp@...ibm.com>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
	"linuxppc-dev@...abs.org" <linuxppc-dev@...abs.org>
Subject: Re: [PATCH] perf_counter/powerpc: Fix compilation after
 perf_counter_overflow change

On Mon, Sep 21, 2009 at 09:30:43AM +0200, Ingo Molnar wrote:
> 
> * Metzger, Markus T <markus.t.metzger@...el.com> wrote:
> 
> > >-----Original Message-----
> > >From: Paul Mackerras [mailto:paulus@...ba.org]
> > >Sent: Monday, September 21, 2009 8:45 AM
> > 
> > 
> > >Markus, please take care in future to mention it in the changelog if
> > >your patches touch definitions used by other architectures.  If you
> > >could go so far as to use grep a bit more and fix up other
> > >architectures' callsites for the things you're changing, that would be
> > >very much appreciated.  Thanks.
> > 
> > I'm sorry I missed that.
> > 
> > There's one more place in arch/sparc/.
> > The below patch should fix it, but I have no means to test it.
> 
> You also missed a third thing:
> 
> +static inline int
> +perf_output_begin(struct perf_output_handle *handle, struct perf_counter *c,
> +                 unsigned int size, int nmi, int sample)               { }
> 
> an 'int' function returning void ...
> 
> Plus all the !PERF_COUNTERS branch of empty inlines is pointless - these 
> facilities are used by perfcounters code only. I fixed that too.

Hi Ingo,

did you fix all of these warnings for !PERF_COUNTERS?

include/linux/perf_counter.h: In function 'perf_output_begin':
include/linux/perf_counter.h:854: warning: no return statement in function returning non-void
include/linux/perf_counter.h: At top level:
include/linux/perf_counter.h:863: warning: 'struct perf_sample_data' declared inside parameter list
include/linux/perf_counter.h:863: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/perf_counter.h:868: warning: 'struct perf_sample_data' declared inside parameter list
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/