linux-kernel - Re: [PATCH] PCI PM: Read device power state from register after updating it (rev. 2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090922091620.599ab046@infradead.org>
Date:	Tue, 22 Sep 2009 09:16:20 +0200
From:	Arjan van de Ven <arjan@...radead.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux PCI <linux-pci@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>
Subject: Re: [PATCH] PCI PM: Read device power state from register after
 updating it (rev. 2)

On Mon, 21 Sep 2009 23:37:01 +0200
"Rafael J. Wysocki" <rjw@...k.pl> wrote:
>  
> -	dev->current_state = state;
> +	pci_read_config_word(dev, dev->pm_cap + PCI_PM_CTRL, &pmcsr);
> +	dev->current_state = (pmcsr & PCI_PM_CTRL_STATE_MASK);
> +	/* Return error code if we have failed to change the state */
> +	if (dev->current_state != state)
> +		dev_info(&dev->dev, "Refused to change power state, "
> +			"currently in D%d\n", dev->current_state);

I would suspect that you want this message only once...
to avoid it flooding logs and such

or at least ratelimiting it


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/