linux-kernel - Re: [origin tree build failure] [PATCH] media: video: Fix build in saa7164

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090922075332.GA32302@elte.hu>
Date:	Tue, 22 Sep 2009 09:53:32 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org
Subject: Re: [origin tree build failure] [PATCH] media: video: Fix build in
	saa7164


* Mauro Carvalho Chehab <mchehab@...hat.com> wrote:

> Em Mon, 21 Sep 2009 20:23:45 +0200
> Ingo Molnar <mingo@...e.hu> escreveu:
> 
> > 
> > * Mauro Carvalho Chehab <mchehab@...hat.com> wrote:
> > 
> > > This series also contains several new drivers:
> > > 
> > >    - new driver for NXP saa7164;
> > 
> > -tip testing found that an allyesconfig build buglet found its way into 
> > this driver - find the fix below.
> > 
> 
> > diff --git a/drivers/media/video/saa7164/saa7164-core.c b/drivers/media/video/saa7164/saa7164-core.c
> > index f0dbead..60f3214 100644
> > --- a/drivers/media/video/saa7164/saa7164-core.c
> > +++ b/drivers/media/video/saa7164/saa7164-core.c
> > @@ -45,8 +45,8 @@ MODULE_LICENSE("GPL");
> >   32 bus
> >   */
> >  
> > -unsigned int debug;
> > -module_param(debug, int, 0644);
> > +unsigned int saa_debug;
> > +module_param(saa_debug, int, 0644);
> 
> Hmm... it is better to use module_param_named(debug, saa_debug, int, 0644), to
> keep presenting the parameter as just "debug" to userspace.

ah, yes, fully agreed - i thought i did that but apparently modified it 
in this instance.

> > This is because recent saa7164 changes introduced a global symbol 
> > named 'debug'. The x86 platform code already defines a 'debug' 
> > symbol. (which is named in a too generic way as well - but it can be 
> > used nicely to weed out too generic symbols in drivers ;-
> 
> Agreed.
> 
> Btw, I suggest to do a similar patch also for x86, to avoid such 
> future conflicts.

Actually, Andrew considers it a feature that allows us to filter out too 
generic names early on :-)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/