[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <19128.38623.956765.684792@cargo.ozlabs.ibm.com>
Date: Tue, 22 Sep 2009 19:20:31 +1000
From: Paul Mackerras <paulus@...ba.org>
To: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc: Ingo Molnar <mingo@...e.hu>, Peter Zijlstra <peterz@...radead.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf_counter: cleanup for __perf_event_sched_in()
Xiao Guangrong writes:
> It must be a group leader if event->attr.pinned is "1"
True, but you shouldn't use BUG_ON unless there is no sensible way for
the kernel to continue executing, and that's not the case here. Make
it WARN_ON, or better still, WARN_ON_ONCE.
Paul.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists