linux-kernel - Re: [PATCH 1/2] Add COH 901 318 DMA block driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1253633602.22454.0.camel@desktop>
Date:	Tue, 22 Sep 2009 08:33:22 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	Maciej Sosnowski <maciej.sosnowski@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Add COH 901 318 DMA block driver

On Tue, 2009-09-22 at 16:38 +0200, Linus Walleij wrote:
> +       val &= ~COH901318_CX_CFG_CH_ENABLE;
> +       writel(val, virtbase + COH901318_CX_CFG +
> +              COH901318_CX_CFG_SPACING * channel);
> +
> +       writel(val, virtbase + COH901318_CX_CFG +
> +              COH901318_CX_CFG_SPACING * channel);
> +       wmb();
> +
> +       /* Spin-wait for it to actually go inactive */
> +       while (readl(virtbase + COH901318_CX_STAT+COH901318_CX_STAT_SPACING *
> +                    channel) & COH901318_CX_STAT_ACTIVE) {}

You might want to add a cpu_relax() here ..

Daniel



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/