linux-kernel - Re: libATA SATA errors on DVD bad sectors...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Sep 2009 10:42:30 -0700
From:	Maciej Żenczykowski <zenczykowski@...il.com>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: libATA SATA errors on DVD bad sectors...

> Later you write that ata12 connects to a Promise SATA300 TX4.
> In that case, port_status 0x20280000 means:
> - Overrun Error
> - Drive Error
> - Packet Command Cycle
> which means that the drive set its error status flag and raised an interrupt which prematurely terminated a data transfer.

Yes, the code in question is here:
http://lxr.linux.no/linux+v2.6.31/drivers/ata/sata_promise.c#L748

> The obvious next experiment would be to swap the drives and see how the Lite-On behaves on the ICH9 and the LG behaves on the TX4.

Yup, did that earlier this morning.  The controller is the cause, not
the drives. (ie. getting the same error on ata12 even though it's now
the LG, the LiteOn on AHCI is now kernel error message free, still
giving IO errors of course)

>  > Would it make sense to add this somewhere into the code as a 'bad sector' error condition and not perform a hard reset?
>
> The sata_promise driver upon seeing the port_status above sets AC_ERR_HSM and AC_ERR_DEV, and performs a soft reset. Apparently libata-eh follows up with a hard(er) reset, which doesn't surprise me given the HSM and DEV errors.

> So things actually work Ok with the Lite-On on the TX4, and you're mainly concerned about log messages and potential performance loss?

Yes, putting the LiteOn on the AHCI controller seems to speed stuff up
a fair bit (some 20-25% or so).
OTOH, I'd prefer to keep the blu-ray drive on AHCI, since the TX4
controller is just a measly PCI controller.

- Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/