linux-kernel - Re: [PATCH 02/21] ceph: on-wire types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0909221120300.1552@cobra.newdream.net>
Date:	Tue, 22 Sep 2009 11:21:44 -0700 (PDT)
From:	Sage Weil <sage@...dream.net>
To:	Joe Perches <joe@...ches.com>
cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, yehuda@...dream.net
Subject: Re: [PATCH 02/21] ceph: on-wire types

On Tue, 22 Sep 2009, Joe Perches wrote:

> On Tue, 2009-09-22 at 10:38 -0700, Sage Weil wrote:
> > These headers describe the types used to exchange messages between the
> > Ceph client and various servers.  All types are little-endian and
> > packed.
> []
> > diff --git a/fs/ceph/ceph_fs.h b/fs/ceph/ceph_fs.h
> > new file mode 100644
> > index 0000000..15150fc
> > --- /dev/null
> > +++ b/fs/ceph/ceph_fs.h
> []
> > +static inline __u32 frag_make(__u32 b, __u32 v)
> > +{
> > +	return (b << 24) |
> > +		(v & (0xffffffu << (24-b)) & 0xffffffu);
> > +}
> 
> frag_<foo> inlines might have a conflict with ipv6

I'll prefix those with 'ceph_'.

> > +static inline const char *ceph_mds_state_name(int s)
> > +{
> > +	switch (s) {
> []
> > +	case CEPH_MDS_STATE_STOPPING:   return "up:stopping";
> > +	default: return "";
> > +	}
> > +	return NULL;
> > +}
> 
> inline?
> 
> It's probably better not to use inlines here
> as the strings could be duplicated unnecessarily.

Agreed.  They were easier to maintain that way when the constants changed 
frequently, but they can be uninlined now.

Thanks!
sage
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/